Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/#329] 사진 3개 등록 대응 #337

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

leemhyungyu
Copy link
Member

이슈 #329

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-27.at.22.47.21.mov

완료된 기능

  • BottlePingPongResponseDTO - otherImageURLs 추가
  • 사진 스크롤 TabView 구현
  • 사진 공개 하단 indicator 추가

고민했던 부분

디자인 요구사항 분석했을 때 사진을 스크롤했을 때 하나씩 넘겨지는 느낌인 거 같아서
ScrollView나 UICollectionView 안쓰고 TabView로 구현하는거로 했어 !
또, 아직 사진 1개인 경우에 어떻게 화면 보여줘야할 지 안나와있길래 일단 1개인 상태에도 동일하게 보이도록 했음 !

@leemhyungyu leemhyungyu self-assigned this Oct 27, 2024
@leemhyungyu leemhyungyu linked an issue Oct 27, 2024 that may be closed by this pull request
@JongHoooon
Copy link
Member

👍🏻

@leemhyungyu leemhyungyu force-pushed the feature/#329-사진-3개-등록-대응 branch from c38e48e to c48a426 Compare November 7, 2024 12:44
@leemhyungyu leemhyungyu merged commit 59e6243 into develop Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

사진 3개 등록 대응
2 participants