Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature/13] github action ip를 동적으로 추가하고 삭제한다 #23

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[feature/13] github action ip를 동적으로 추가하고 삭제한다 #23

merged 1 commit into from
Jul 23, 2024

Conversation

injoon2019
Copy link
Collaborator

💡 이슈 번호

close: #13

✨ 작업 내용

github action ip를 deploy시 동적으로 ec2 규칙에 추가/삭제합니다.

🚀 전달 사항

  • 추가된 secret은 디스코드에 추가하여 수정했습니다.
  • ec2에 0.0.0.0으로 열린 인바운드 규칙은 삭제할 예정입니다

@injoon2019 injoon2019 changed the title feat: github action ip를 동적으로 추가하고 삭제한다 [feature/13] github action ip를 동적으로 추가하고 삭제한다 Jul 22, 2024
@injoon2019 injoon2019 self-assigned this Jul 22, 2024
miseongk
miseongk approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@miseongk miseongk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 너무 좋네요 👍👍👍

@injoon2019 injoon2019 merged commit 6d19d6e into develop Jul 23, 2024
1 check passed
@injoon2019 injoon2019 deleted the feature/13 branch July 23, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miseongk miseongk miseongk approved these changes

Assignees

@injoon2019 injoon2019

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github Action IP로 SSH 접속 가능하도록 deploy workflow를 수정한다
2 participants
@injoon2019 @miseongk