Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Habitat_confirmations spreadsheet #65

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

lucy-schick
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi - the UTM method in the skeena 2022 repo was incorrect. peace 2022 however was correct. Our method is most commonly GPS General. GIS is when you derive the points in something like Q. although we do that sometimes (ex. move points) - it is almost always based on our GPS unit points and tracks

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay. Let me know if you want me to correct UTM method or if you will do that in next PR?

@@ -755,6 +756,9 @@ plot_fish_hist


####-----------summary tables for input to spreadsheet----------------------
dir_gis <- 'sern_skeena_2023'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is cool

@@ -793,17 +795,53 @@ hab_fish_input <- left_join(
# a hack to get number of columns right
fish_activity = age,
comments) %>%
mutate(model = case_when(local_name %like% 'ef' ~ 'halltech HT2000'),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are tons of old examples of using data.table %like% and %ilike% but we should strive to get away from it to reduce dependencies by using tidyverse equivalents. NewGraphEnvironment/fpr#72 discusses this for fpr and we commonly use stringr::str_detect elsewhere. keen to ditch data.table one day. tidyverse is mostly catching and surpassing it for most things. there are other places it was necessary in the past (see creation of watershed summary stats) so not sure if we will get all the way there this spring

hab_fish_input %>%
readr::write_csv(file = paste0(getwd(), '/data/inputs_extracted/hab_con_fish_summary.csv'),
readr::write_csv(file = paste0('data/inputs_extracted/hab_con_fish_summary.csv'),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for paste0 once we ditch getwd

Copy link
Owner

@NewGraphEnvironment NewGraphEnvironment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@NewGraphEnvironment NewGraphEnvironment merged commit 3d95fb6 into NewGraphEnvironment:main Apr 25, 2024
@lucy-schick
Copy link
Collaborator Author

Thank you!

@lucy-schick lucy-schick deleted the hab_conf branch May 8, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants