Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build errors on macOS #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wowazzz
Copy link

@wowazzz wowazzz commented Jan 11, 2022

These changes return cross-platform capability to the project.

As I wrote in commits before, using global variables std::string, std::deque, ... types is a bad practice.
So, CLang compiler failry gives as -Wglobal-constructors -Wexit-time-destructors warning-as-errors.

At least, we can use this way:

#ifdef __APPLE__
#define NODESTROY [[clang::no_destroy]]
#else
#define NODESTROY
#endif

to bring cross-platform back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant