Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes return cross-platform capability to the project.
As I wrote in commits before, using global variables
std::string
,std::deque
,...
types is a bad practice.So, CLang compiler failry gives as -Wglobal-constructors -Wexit-time-destructors warning-as-errors.
At least, we can use this way:
catapult-server/plugins/txes/price/src/observers/priceUtil.h
Lines 7 to 11 in 5f92b3c
to bring cross-platform back.