Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/move sync server to di #7742

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Refactor/move sync server to di #7742

merged 2 commits into from
Nov 11, 2024

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Nov 9, 2024

  • Move SyncServer to di.
  • Cut some code down.
  • Ensure sync server is disposed, although the dispose does not really to anything significant.

Types of changes

What types of changes does your code introduce?

  • Refactoring

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@asdacap asdacap merged commit 6ab6e65 into master Nov 11, 2024
77 checks passed
@asdacap asdacap deleted the refactor/move-sync-server-to-di branch November 11, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asdacap @LukaszRozmej