Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify environment variables #7694

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Unify environment variables #7694

wants to merge 8 commits into from

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Oct 31, 2024 •
edited
Loading

Resolves #7684

Changes

  • Removed NETHERMIND_URL
  • Removed NETHERMIND_ENODE_IPADDRESS
  • Replaced NETHERMIND_CORS_ORIGINS with IJsonRpcConfig.CorsOrigins
  • Replaced NETHERMIND_MONITORING_GROUP with IMetricsConfig.MonitoringGroup
  • Replaced NETHERMIND_MONITORING_JOB with IMetricsConfig.MonitoringJob

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

rubo
rubo commented Oct 31, 2024
View reviewed changes
src/Nethermind/Nethermind.Runner/JsonRpc/Startup.cs
app.UseRouting();
app.UseCors();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UseCors() must come after UseRouting()

@rubo rubo marked this pull request as ready for review November 1, 2024 19:17
@rubo rubo assigned asdacap and unassigned asdacap Nov 1, 2024
@rubo rubo requested a review from asdacap November 1, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcindsobczak marcindsobczak marcindsobczak approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@smartprogrammer93 smartprogrammer93 Awaiting requested review from smartprogrammer93

@asdacap asdacap Awaiting requested review from asdacap

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify environment variables
4 participants
@rubo @LukaszRozmej @marcindsobczak @asdacap