Implement EIP-7623: Increase calldata cost #7539
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ben Adams <[email protected]> Co-authored-by: Kamil Chodoła <[email protected]> Co-authored-by: nethermind-machine <[email protected]> Co-authored-by: LukaszRozmej <[email protected]> Co-authored-by: Daniel Kyutae Jung <[email protected]> Co-authored-by: Ahmad Bitar <[email protected]> Co-authored-by: Lukasz Rozmej <[email protected]> Co-authored-by: Amirul Ashraf <[email protected]> Co-authored-by: yerke26 <[email protected]> Co-authored-by: yeerke <[email protected]> Co-authored-by: Ruben Buniatyan <[email protected]> Co-authored-by: Alexey <[email protected]> Co-authored-by: Nikita Mescheryakov <[email protected]> Co-authored-by: Lautaro Emanuel <[email protected]> Co-authored-by: Marcos Antonio Maceo <[email protected]> Co-authored-by: ak88 <[email protected]> Co-authored-by: Yaroslav Kukharuk <[email protected]> Co-authored-by: Marek Moraczyński <[email protected]> Co-authored-by: Ahmad Bitar <[email protected]> Co-authored-by: Oleg Jakushkin <[email protected]> Co-authored-by: Kamil Chodoła <[email protected]> Co-authored-by: healthyyyoung <[email protected]>
…ethermind into feature/eip-7702
MarekM25
reviewed
Oct 4, 2024
| // This is unnecessarily calculated twice - at validation and execution times. | ||
| transaction.GasLimit < IntrinsicGasCalculator.Calculate(transaction, releaseSpec) | ||
| var intrinsicGas = IntrinsicGasCalculator.Calculate(transaction, releaseSpec, out var floorGas); |
There was a problem hiding this comment.
I wonder if there's a more elegant way to handle this than using an out parameter. For example, the IntrinsicGasCalculator could encapsulate the transaction validation logic within the class itself.
| @@ -343,7 +344,7 @@ protected TransactionResult ValidateStatic( | |||
| return "EIP-3860 - transaction size over max init code size"; | |||
| } | |||
|
|
|||
| return ValidateGas(tx, header, intrinsicGas, validate); | |||
| return ValidateGas(tx, header, Math.Max(intrinsicGas, floorGas), validate); | |||
There was a problem hiding this comment.
Oh I see it is needed here. Perhaps, out is the best solution then, but think about it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7527
https://eips.ethereum.org/EIPS/eip-7623
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.