Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify environment variables #7684

Open
rubo opened this issue Oct 29, 2024 · 0 comments · May be fixed by #7694
Open

Unify environment variables #7684

rubo opened this issue Oct 29, 2024 · 0 comments · May be fixed by #7694
Assignees
@rubo

Comments

@rubo
Copy link
Contributor

rubo commented Oct 29, 2024

A few old environment variables don't follow the naming convention that all other environment variables do, so they are not automatically documented and, therefore, rarely used:

  • NETHERMIND_CORS_ORIGINS: convert to JsonRpc.CorsOrigins
  • NETHERMIND_ENODE_IPADDRESS: remove as a duplicate of NETHERMIND_NETWORKCONFIG_EXTERNALIP
  • NETHERMIND_MONITORING_GROUP: convert to Metrics.MonitoringGroup
  • NETHERMIND_MONITORING_JOB: convert to Metrics.MonitoringJob
  • NETHERMIND_URL: remove as redundant and conflicting with JsonRpc.Host and JsonRpc.Port
@rubo rubo self-assigned this Oct 29, 2024
@rubo rubo linked a pull request Oct 31, 2024 that will close this issue
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rubo rubo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify environment variables NethermindEth/nethermind
1 participant
@rubo