Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added config file parameter and command-line option, improved handling without testparm, relaxed Content-Type checks #51

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Added config file parameter and command-line option, improved handling without testparm, relaxed Content-Type checks #51

wants to merge 10 commits into from

Conversation

oldium
Copy link

@oldium oldium commented Apr 17, 2024 •
edited
Loading

This Pull Request contains multiple fixes and improvements:

  • Compile-time fixes for sockelen_t usages and printf size_t/ssize_t usages
  • More relaxed Content-Type value checking - allow semicolon and spaces around the expected value
  • Added missing -A and -B options, which are described in the help text
  • Allow usage completely without testparm, indicate this in the help output
  • When printing help, first process all options and indicate actual values in the help output
  • Added logging of read values from configuration

Obsoletes: #44

@oldium
Fix compile-time printf size_t and ssize_t warnings
30a8c16 
Signed-off-by: Oldřich Jedlička <[email protected]>
@oldium
Fix compile-time warning about not using socklen_t pointer
2bf5e2b 
Signed-off-by: Oldřich Jedlička <[email protected]>
@oldium
Fix recognition of Content-Type
ac9f188 
Enhance check of Content-Type value by allowing space or semicolon after
the value.

Signed-off-by: Oldřich Jedlička <[email protected]>
@oldium
Add missing -A and -B options
d2132c9 
Signed-off-by: Oldřich Jedlička <[email protected]>
@oldium
Allow startup without testparm
f11827c 
When testparm is missing, simply use hostname as a basis for hostname
and netbiosname parameters.

Signed-off-by: Oldřich Jedlička <[email protected]>
@oldium
Allow non-default smb.conf location and config file option
6976438 
Signed-off-by: Oldřich Jedlička <[email protected]>
@oldium
Better overriding options from command line
ca9228b 
First process command line options and then set the missing values. For
help purposes initialize the mising defaults in order to show effective
values.

Signed-off-by: Oldřich Jedlička <[email protected]>
@oldium
Log successful value query
d241f21 
Signed-off-by: Oldřich Jedlička <[email protected]>
@oldium
Accept not-found value from testparm
dab53d0 
The not-found is simply an empty line.

Signed-off-by: Oldřich Jedlička <[email protected]>
@oldium
Indicate usage of samba configuration (i.e. testparm) in help output
d7c9e1c 
Signed-off-by: Oldřich Jedlička <[email protected]>
@oldium oldium mentioned this pull request Apr 17, 2024
Open
@oldium oldium changed the title Added config file parameter and command-line option, improved handling without testparm Added config file parameter and command-line option, improved handling without testparm, relaxed Content-Type checks Apr 17, 2024
@lherschi
Copy link

The code can be built in my cross-compiler environment.

@oldium oldium marked this pull request as ready for review May 27, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oldium @lherschi