This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Remove hard-coded UID 1000 for nem account #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the system to dynamically determine the appropriate UID. Improves compatibility for hosts with existing user accounts.
Allows the system to dynamically determine the appropriate UID. Improves compatibility for hosts with existing user accounts.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to let the host determine the appropriate UID. Most hosts with existing user accounts will have already assigned UID 1000; allowing the host to determine an appropriate ID for the nem account should improve compatibility.
I am not clear why the UID was originally included, so this change could have unintended consequences if the UID is required in certain cases / Linux distributions. If the UID is required in some scenarios, adding instructions or UID querying logic would be preferred.