Make pretty JSON formatting optional in basic formatter #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hkrutzer Good catch! Please instead of making it an option just remove it. This is just a leftover after a total rewrite. |
AndrewDryga
reviewed
Apr 26, 2024
lib/logger_json/formatters/basic.ex
Outdated
| @@ -44,7 +45,7 @@ defmodule LoggerJSON.Formatters.Basic do | |||
| |> maybe_put(:request, format_http_request(meta)) | |||
| |> maybe_put(:span, format_span(meta)) | |||
| |> maybe_put(:trace, format_trace(meta)) | |||
| |> Jason.encode_to_iodata!(pretty: true) | |||
| |> Jason.encode_to_iodata!(pretty: pretty_json) | |||
There was a problem hiding this comment.
Suggested change
| |> Jason.encode_to_iodata!(pretty: pretty_json) | |
| |> Jason.encode_to_iodata!() |
hkrutzer
force-pushed
the
optional_pretty_json
branch
from
24cc0df to
db6c491
Compare
hkrutzer
force-pushed
the
optional_pretty_json
branch
from
db6c491 to
d77c75b
Compare
|
Thanks, removed it! |
|
Thank you! @hkrutzer |
|
Thanks @AndrewDryga. Are you planning on publishing 6.x to hex.pm anytime soon? |
|
@hkrutzer yes, I'm just trying to test it in our production to make sure it won't fail in yours. I think I will bump the version early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some log processors can't process JSON logs if they are spread across multiple lines.
I saw the other formatters don't have
prettyat all so I'm not sure if it's intentional.