Add automated cleanup to ONT instrument transfer script #443
+98
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the preproc archive dir
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #443 +/- ##
=========================================
Coverage ? 29.13%
=========================================
Files ? 31
Lines ? 4984
Branches ? 0
=========================================
Hits ? 1452
Misses ? 3532
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete runs from the instrument which are found in the
destination/nosyncsubdir on the mounted storage.Initially the idea was to also look in e.g. the
transfer_promethion.tsvfile, but it's located in the home dir of the preproc server itself rather than its mounted storage and so the instrument has no read access from what I can tell.This PR thus makes the assumption that any run moved to the nosync subdir of the mounted storage has also been sent to miarka.
I considered taking it one step further and looking at
destination/nosync/archived, but I'm not sure to what extent the archiving is automated, and this subdir is missing for e.g. MinION QC runs.