Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FINNA-2789] EAD3: Add top hierarchy type to all levels #166

Merged
merged 6 commits into from
Nov 28, 2024
Merged

[FINNA-2789] EAD3: Add top hierarchy type to all levels #166

merged 6 commits into from
Nov 28, 2024

Conversation

siiriylonen
Copy link
Contributor

No description provided.

@siiriylonen siiriylonen changed the title [FINNA-2789] Add top hierarchy type to all levels [FINNA-2789] EAD3: Add top hierarchy type to all levels Nov 13, 2024
@siiriylonen
Copy link
Contributor Author

I've now split them like so and this would be the follow-up: NatLibFi/RecordManager-Finna#73

@siiriylonen siiriylonen marked this pull request as ready for review November 13, 2024 06:57
EreMaijala
EreMaijala requested changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@EreMaijala EreMaijala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voisi tehdä niin, että koko add-data:n lisäys siirretään omaan metodiin, jolloin sen voi yliajaa Finna-versiossa. Kutsu tyyliin $this->addAdditionalData($record);. Näin ei tarvitse lisätä mitään tietämystä type-attribuutista.

@EreMaijala EreMaijala merged commit 02c7fca into NatLibFi:dev Nov 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EreMaijala EreMaijala EreMaijala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siiriylonen @EreMaijala