Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FINNA-2060] LIDO: fix geographic indexing from repository locations #157

Conversation

siiriylonen
Copy link
Contributor

No description provided.

@siiriylonen siiriylonen marked this pull request as ready for review March 28, 2024 07:35
@siiriylonen
Copy link
Contributor Author

I have now done this similarly as was in vufind and there it seemed only the repositorySet, which has "Current location", was collected to locations. However, I'm not completely sure that's the case or how it should be here.

src/RecordManager/Base/Record/Lido.php Outdated Show resolved Hide resolved
src/RecordManager/Base/Record/Lido.php Outdated Show resolved Hide resolved
src/RecordManager/Base/Record/Lido.php Outdated Show resolved Hide resolved
@siiriylonen siiriylonen requested a review from EreMaijala April 5, 2024 11:19
src/RecordManager/Base/Record/Lido.php Outdated Show resolved Hide resolved
src/RecordManager/Base/Record/Lido.php Outdated Show resolved Hide resolved
src/RecordManager/Base/Record/Lido.php Outdated Show resolved Hide resolved
@siiriylonen siiriylonen requested a review from EreMaijala April 15, 2024 05:20
@EreMaijala EreMaijala merged commit f8e638a into NatLibFi:dev Apr 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants