Rename export function

This should be less confusing
Nadybot · Feb 20, 2024 · cc9d2b1 · cc9d2b1
1 parent 04055ac
commit cc9d2b1
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/src/BasicClient.php b/src/BasicClient.php
@@ -159,7 +159,7 @@ public function read(): ?Package\In {
 	}
 
 	public function write(Package\Out $package): void {
-		$binPackage = $package->toBinary();
+		$binPackage = $package->toBinaryPackage();
 		$this->connection->write($binPackage->toBinary());
 	}
 

diff --git a/src/Package.php b/src/Package.php
@@ -46,7 +46,7 @@ public function __toString() {
 		return "<{$class}>{" . join(",", $values) . "}";
 	}
 
-	public function toBinary(): BinaryPackage {
+	public function toBinaryPackage(): BinaryPackage {
 		$type = $this->type;
 		$format = $this->getFormat();
 		$values = $this->getPackageValues();

diff --git a/src/Package/In.php b/src/Package/In.php
@@ -5,8 +5,8 @@
 use AO\{BinaryPackage, Package};
 
 abstract class In extends Package {
-	public function toBinary(): BinaryPackage\In {
-		$package = parent::toBinary();
+	public function toBinaryPackage(): BinaryPackage\In {
+		$package = parent::toBinaryPackage();
 		return new BinaryPackage\In(
 			type: $package->type,
 			length: $package->length,

diff --git a/src/Package/Out.php b/src/Package/Out.php
@@ -5,8 +5,8 @@
 use AO\{BinaryPackage, Package};
 
 abstract class Out extends Package {
-	public function toBinary(): BinaryPackage\Out {
-		$package = parent::toBinary();
+	public function toBinaryPackage(): BinaryPackage\Out {
+		$package = parent::toBinaryPackage();
 		return new BinaryPackage\Out(
 			type: $package->type,
 			length: $package->length,

diff --git a/tests/ParserTest.php b/tests/ParserTest.php
@@ -60,7 +60,7 @@ public static function examplePackages(): array {
 	#[DataProvider('examplePackages')]
 	public function testPackagesBackAndForth(Package $package): void {
 		$parser = Parser::createDefault(TestLogger::create());
-		$binPackage = $package->toBinary();
+		$binPackage = $package->toBinaryPackage();
 		$this->assertInstanceOf(BinaryPackage::class, $binPackage);
 		$reconverted = $parser->parseBinaryPackage($binPackage);
 		$this->assertSame(serialize($package), serialize($reconverted));