Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSD-1889: POC for <search> exploration #1714

Closed
wants to merge 5 commits into from

Conversation

7emansell
Copy link
Collaborator

@7emansell 7emansell commented Dec 12, 2024

Fixes JIRA ticket DSD-1889. See this document for explanation behind these proposed changes.

This PR does the following:

  • Most importantly: removes role="search" from form element within Searchbar
  • Adds recommendation to use <search> in Searchbar documentation
  • Creates new page in Reservoir accessibility guide for ARIA landmarks

How has this been tested?

Accessibility concerns or updates

  • Updating use of search role in response to new HTML search element

Accessibility Checklist

  • Checked Storybook's "Accessibility" tab for color contrast and other issues.
  • The feature works with keyboard inputs including tabbing back and forward and pressing space, enter, arrow, and esc keys.
  • For hidden text or when aria-live is used, a screenreader was used to verify the text is read.
  • For features that involve UI updates and focusing on DOM refs, focus management was reviewed.
  • The feature works when the page is zoomed in to 200% and 400%.

Open Questions

Checklist:

  • I have updated the Storybook documentation and changelog accordingly.
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Front End Review:

  • Review the Vercel preview deployment once it is ready.

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nypl-design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 5:22pm

Copy link

Your pull request is missing a changelog—was that intentional?

@7emansell
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
POC v4 Updates for the v4.0 feature branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants