Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSD-1633: spacing for FeaturedContent #1469

Merged
merged 4 commits into from
Dec 1, 2023
Merged

DSD-1633: spacing for FeaturedContent #1469

merged 4 commits into from
Dec 1, 2023

Conversation

bigfishdesign13
Copy link
Collaborator

@bigfishdesign13 bigfishdesign13 commented Nov 30, 2023 •
edited
Loading

Fixes JIRA ticket DSD-1633

This PR does the following:

  • Updates the FeaturedContent component by adjusting the spacing in the "fullScreen" variant to better align the component text content with the page text content.
  • NOTE: Nothing was really changed in FeaturedContent.mdx. Only the text wrapping was updated, so don't worry about reviewing that file.

How has this been tested?

  • local Storybook

Accessibility concerns or updates

  • n/a

Checklist:

  • I have updated the Storybook documentation accordingly.
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Front End Review:

  • Review the Vercel preview deployment once it is ready.

@vercel Vercel
Copy link

vercel bot commented Nov 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nypl-design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 11:27pm

7emansell
7emansell approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@7emansell 7emansell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

EdwinGuzman
EdwinGuzman approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@EdwinGuzman EdwinGuzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. It's a bit hard to see it in Storybook but will make more sense when we review in Turbine/DC.

The mobile left alignment does look odd to me, but it is intended, right?

Screen Shot 2023-11-30 at 5 15 11 PM

src/theme/components/featuredContent.ts Outdated Show resolved Hide resolved
@bigfishdesign13
Copy link
Collaborator Author

The mobile left alignment does look odd to me, but it is intended, right?

@EdwinGuzman Yes, that is intended. It puts the text content in the component in line with the text content on the page.

@bigfishdesign13 bigfishdesign13 added the Ship It Pull requests that have been reviewed and approved. label Nov 30, 2023
@bigfishdesign13 bigfishdesign13 merged commit 572964c into development Dec 1, 2023
5 checks passed
@bigfishdesign13 bigfishdesign13 deleted the DSD-1633/featuredcontent-spacing branch December 1, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7emansell 7emansell 7emansell approved these changes

@EdwinGuzman EdwinGuzman EdwinGuzman approved these changes

Assignees
No one assigned
Labels
Ship It Pull requests that have been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bigfishdesign13 @EdwinGuzman @7emansell