DSD-1630: Adding and passing down isLazy from Card to its Image component #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwinGuzman
requested review from
bigfishdesign13,
jackiequach,
oliviawongnyc and
7emansell
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bigfishdesign13
approved these changes
Nov 27, 2023
bigfishdesign13
added
Ship It
* development: NYPL color design tokens in DC logo changelog for Text component updated font weight for subtitle styles Merges in development Updates per PR feedback More cleanup Cleans up theme file, updates changelog Adds hasVisitedState prop to Link and updates documentation Updates CHANGELOG Updates zIndex for searchbar select icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JIRA ticket DSD-1630
This PR does the following:
isLazyimage prop from theCardcomponent down to its ownImagecomponent. This way, an image-heavy page that uses theCardto render images can lazy load images.How has this been tested?
Locally and in Storybook. To test, open up the "Network" tab in chrome's console, load the page, and scroll down to see images fetched as you scroll.
Accessibility concerns or updates
Checklist:
Front End Review: