Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSD-1618: autoComplete prop for TextInput #1457

Merged
merged 2 commits into from
Nov 7, 2023
Merged

DSD-1618: autoComplete prop for TextInput #1457

merged 2 commits into from
Nov 7, 2023

Conversation

bigfishdesign13
Copy link
Collaborator

Fixes JIRA ticket DSD-1618

This PR does the following:

  • Added the autoComplete prop to the TextInput component.

How has this been tested?

  • local Storybook

Accessibility concerns or updates

  • The autoComplete prop will provide additional methods to improve a11y in consuming apps.

Checklist:

  • I have updated the Storybook documentation accordingly.
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Front End Review:

  • Review the Vercel preview deployment once it is ready.

@vercel Vercel
Copy link

vercel bot commented Nov 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nypl-design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 4:39pm

@bigfishdesign13 bigfishdesign13 added the Needs Review Pull requests that are ready for peer review. label Nov 2, 2023
EdwinGuzman
EdwinGuzman reviewed Nov 3, 2023
View reviewed changes
Copy link
Member

@EdwinGuzman EdwinGuzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions but looks good overall.

src/components/TextInput/TextInput.mdx Outdated Show resolved Hide resolved
src/components/TextInput/TextInput.tsx Show resolved Hide resolved
@bigfishdesign13 bigfishdesign13 added Ship It Pull requests that have been reviewed and approved. and removed Needs Review Pull requests that are ready for peer review. labels Nov 7, 2023
@bigfishdesign13 bigfishdesign13 merged commit 7954414 into development Nov 7, 2023
4 checks passed
@bigfishdesign13 bigfishdesign13 deleted the DSD-1618/textinput-autocomplete branch November 7, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdwinGuzman EdwinGuzman EdwinGuzman approved these changes

@oliviawongnyc oliviawongnyc Awaiting requested review from oliviawongnyc

@dgcohen dgcohen Awaiting requested review from dgcohen

@7emansell 7emansell Awaiting requested review from 7emansell

@jackiequach jackiequach Awaiting requested review from jackiequach

Assignees
No one assigned
Labels
Ship It Pull requests that have been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigfishdesign13 @EdwinGuzman