Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSD-1520: Add sizeBasedOn prop to Logo #1456

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

jackiequach
Copy link
Collaborator

Fixes JIRA ticket 1520

This PR does the following:

  • Adds sizeBasedOn prop to Logo and corresponding info in Storybook docs
  • Adds snapshot test for size based on height

How has this been tested?

Locally in Storybook

Accessibility concerns or updates

  • N/A

Checklist:

  • I have updated the Storybook documentation accordingly.
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Front End Review:

  • Review the Vercel preview deployment once it is ready.

Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nypl-design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 4:59pm

Copy link
Member

@EdwinGuzman EdwinGuzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I was trying to see if the logic in logo.ts could be done so that there's one object since the pixel values are the same for both size and sizeBasedOn. But the maxWidth and maxHeight does make that a bit difficult, and also the largest two sizes.

One thing that this is missing is the new component changelog table. Here's an example implementation: https://github.com/NYPL/nypl-design-system/blob/development/src/components/Slider/Slider.mdx#L339
and an example data file: https://github.com/NYPL/nypl-design-system/blob/development/src/components/Slider/sliderChangelogData.ts

Copy link
Member

@EdwinGuzman EdwinGuzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the last update. Let's also wait for Marty to review because he knows the styles better than I do.

Copy link
Collaborator

@bigfishdesign13 bigfishdesign13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Just make sure to update the TOC on the story page.

src/components/Logo/Logo.mdx Show resolved Hide resolved
@bigfishdesign13 bigfishdesign13 added the Ship It Pull requests that have been reviewed and approved. label Nov 6, 2023
@bigfishdesign13 bigfishdesign13 merged commit 47cff7e into development Nov 7, 2023
4 checks passed
@bigfishdesign13 bigfishdesign13 deleted the DSD-1520/logo-sizeBasedOn branch November 7, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ship It Pull requests that have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants