Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSD-1612: Updating Chakra UI to max version of 1.8.9 #1452

Merged
merged 2 commits into from
Nov 7, 2023
Merged

DSD-1612: Updating Chakra UI to max version of 1.8.9 #1452

merged 2 commits into from
Nov 7, 2023

Conversation

EdwinGuzman
Copy link
Member

Fixes JIRA ticket DSD-1612

This PR does the following:

  • Updates the max version of Chakra UI to 1.8.9 (from 1.8.8). This fixes minor bugs in Chakra.

How has this been tested?

Locally.

Accessibility concerns or updates

  • N/A

Checklist:

  • I have updated the Storybook documentation accordingly.
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Front End Review:

  • Review the Vercel preview deployment once it is ready.

@EdwinGuzman EdwinGuzman added the Needs Review Pull requests that are ready for peer review. label Oct 27, 2023
@vercel
Copy link

vercel bot commented Oct 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nypl-design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 10:10pm

bigfishdesign13
bigfishdesign13 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@bigfishdesign13 bigfishdesign13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice that they are still maintaining v1.

@bigfishdesign13 bigfishdesign13 added Ship It Pull requests that have been reviewed and approved. and removed Needs Review Pull requests that are ready for peer review. labels Oct 30, 2023
@EdwinGuzman EdwinGuzman merged commit d678291 into development Nov 7, 2023
4 checks passed
@EdwinGuzman EdwinGuzman deleted the DSD-1612/chakra-minor-update branch December 1, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigfishdesign13 bigfishdesign13 bigfishdesign13 approved these changes

Assignees
No one assigned
Labels
Ship It Pull requests that have been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdwinGuzman @bigfishdesign13