SFR-2440/search_sort_desc_date #500
Open
+62
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| from .utils import assert_response_status | ||
|
|
||
| @pytest.mark.parametrize("endpoint, expected_status", [ | ||
| ("/search?query=keyword%3ANASA&sort=date%3Adesc&filter=language%3ASerbian", 200), |
There was a problem hiding this comment.
Recommend using urllib.parse.quote to escape the URL keys just to make it more readable.
There was a problem hiding this comment.
You can create a separate part of the tuple here for the language filter. Below you can then do
assert item.get('language') == expected_language, f"Unexpected language: {item.get('language')}"
| assert response.status_code is not None | ||
| assert_response_status(url, response, expected_status) | ||
|
|
||
| if expected_status == 200: |
There was a problem hiding this comment.
the assert_response_status above will cause the test to fail if the expected_status is not 200. I think we can remove this if
Comment on lines
+23
to
+31
| previous_date = None | ||
| for item in response_json.get('results', []): | ||
| current_date = item.get('publication_date') | ||
| assert current_date is not None, "Publication date is missing" | ||
|
|
||
| if previous_date: | ||
| assert current_date >= previous_date, f"Publication dates are not sorted in descending order: {previous_date} > {current_date}" | ||
|
|
||
| previous_date = current_date |
There was a problem hiding this comment.
You could simplify this:
publication_dates = [item.get('publication_date') for item in response_json.get('results', [])]
assert all(publication_date is not None for publication_date in publication_dates), f"Some publication dates are missing: {dates}"
assert publication_dates == sorted(publication_dates, reverse=True), f"Dates are not sorted in descending order: {dates}"
| assert current_date is not None, "Publication date is missing" | ||
|
|
||
| if previous_date: | ||
| assert current_date >= previous_date, f"Publication dates are not sorted in descending order: {previous_date} > {current_date}" |
There was a problem hiding this comment.
Is it ascending or descending order?
There was a problem hiding this comment.
Ok probably makes sense to just do the sort order as part of the paramerterization of the test case instead of a separate file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following