Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFR-2438: Fix Fulfill URL Manifest Process #495

Merged
merged 8 commits into from
Jan 7, 2025
Merged

SFR-2438: Fix Fulfill URL Manifest Process #495

merged 8 commits into from
Jan 7, 2025

Conversation

kylevillegas93
Copy link
Contributor

@kylevillegas93 kylevillegas93 commented Jan 2, 2025

Description

  • The Fulfill URL Manifest process was using different incorrect class variables
  • This change fixes typos!

Testing

python main.py -p FulfillURLManifestProcess -e local -i complete
python main.py -p FulfillURLManifestProcess -e local -i daily
make unit

@@ -41,6 +41,7 @@ class APIUtils():
'muse': 4,
'met': 5,
'isac': 6,
'UofMichigan': 7,
'UofM': 7,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't have any files ingested in production under UofM, do we need both?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since we have both in QA, we will need both!

@kylevillegas93 kylevillegas93 merged commit a240de4 into main Jan 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants