Add BranchCodesMap alarms #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove chrome_installer and add alarm for timestamps divisible by 96
aaronfriedman6
assigned fatimarahman and aaronfriedman6 and unassigned fatimarahman and aaronfriedman6
fatimarahman
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The location_hours table uses the Drupal branch id while most other tables use the Sierra branch id. In order to translate from one to the other we use the branch_codes_map table, which is maintained by hand. These new alarms test that all the Drupal ids in location_hours also exist in branch_codes_map and that all the Sierra codes in branch_codes_map also exist in location_hours. Also that each Sierra code maps to a single Drupal id (the reverse is not true, as sometimes there are old Sierra codes that are actually the same branch -- e.g. my and lp are both LPA).
Also renamed LocationVisits to GranularLocationVisits to avoid confusion with the daily_location_visits table.