Fix compilation with exceptions disabled on MSVC and remove use of alloca #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling NVRHI with exceptions disabled (not necessarily supported, but not uncommon in game engines), the use of
allocaind3d12-raytracing.cppcauses a compilation errors on MSVC becauseallocais defined in<malloc.h>which is included by<exception>(which is included by<string>) only when_HAS_EXCEPTIONSis not 0.Instead of just including
<malloc.h>which is compiler and OS-specific I decided to just replace the usage ofallocawith a preallocated vector since it is generally considered bad practice to useallocaand it's only used in this one specific place in NVRHI.