Add schema visitor. #2548
Merged
Add schema visitor. #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: liurenjie1024 <[email protected]>
|
build |
Signed-off-by: liurenjie1024 <[email protected]>
|
build |
jlowe
previously approved these changes
Oct 30, 2024
| * <li> Visit primitive field b1</li> | ||
| * <li> Visit list field B with results from b1 and previsit result. </li> | ||
| * <li> Visit primitive field c1</li> | ||
| * <li> Visit with results from columns A, B, and C</li> |
There was a problem hiding this comment.
This just says "Visit with ..." which begs the question of visit what? Is this visitTopSchema?
| T visitStruct(HostColumnVectorCore col, List<T> children); | ||
|
|
||
| /** | ||
| * Visit a list column before actually visiting its child. |
There was a problem hiding this comment.
It's a bit odd and asymmetric that lists get a previsit before children but structs do not. Curious why this is needed?
There was a problem hiding this comment.
Because for list's child, we need know the offset and length of its child from list's offset buffer first. For example, for list<int>, we want to serialize from [3, 9), which is list's offset and length, but the offset and length of its child is unknown without actually visiting list's offset buffer.
Signed-off-by: liurenjie1024 <[email protected]>
|
build |
GaryShen2008
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of introducing kudo, for a more complete pr please refer to #2532.
In this pr we introduced a post order visitor for schema and host column vectors.