Fix NV2080_CTRL_CMD_GPU_GET_PID_INFO don't work correctly in container #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When call nvmlDeviceGetComputeRunningProcesses_v3() in container, the pid returned is convert by _gpuConvertPid, and will get the pid which is inside the namespace, but not the globle one. When user use the pid to call NV2080_CTRL_CMD_GPU_GET_PID_INFO, we do not do that fasion translation, just compare it with ProcID, this leads users get NULL data inside container. To fix this issue, just keep the same, do the translation, so that apps could get the pid data. Signed-off-by: Michael Qiu <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When call nvmlDeviceGetComputeRunningProcesses_v3() in container, the pid returned is convert by _gpuConvertPid, and will get the pid which is inside the namespace, but not
the globle one. When user use the pid to call
NV2080_CTRL_CMD_GPU_GET_PID_INFO, we do not do that fasion translation, just compare it with ProcID, this leads users get NULL data inside container.
To fix this issue, just keep the same, do the translation, so that apps could get the pid data.