Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drm: remove drivers trying to take the framebuffer #356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YusufKhan-gamedev
Copy link

Signed-off-by: Yusuf Khan [email protected]

@mtijanic
Copy link
Collaborator

mtijanic commented Sep 6, 2022

Hey, just a heads up, this isn't being ignored, it has just stalled while waiting on some of our key engineers to become available. The few of us that do have the bandwidth don't have enough domain expertise to understand all the implications.

Someone will hopefully get to this soon enough. Thanks for the patience!

@muellerjoel
Copy link

I used with ArchLinux Kernel 5.19.11 and nvidia-open-git-dkms package and didn’t fix me issue with the framebuffer

Copy link

@TheDevMinerTV TheDevMinerTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo

* might.
*/
#if defined(NV_LINUX_APERTURE_H_PRESENT)
/* Linux 6.0-rc1 has this, the drm apreture func wraps this */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* Linux 6.0-rc1 has this, the drm apreture func wraps this */
/* Linux 6.0-rc1 has this, the drm aperture function wraps this */

@sl1pkn07 sl1pkn07 mentioned this pull request Nov 19, 2022
@vars1ty
Copy link

vars1ty commented Aug 19, 2023

It's been almost an entire year, how is this still not merged? Surely there has been enough time for people to look at it (and other PRs).

@aaronp24
Copy link
Member

It's been almost an entire year, how is this still not merged? Surely there has been enough time for people to look at it (and other PRs).

I don't think this can be merged as-is, since in addition to removing conflicting drivers such as nouveau, it will also remove important drivers such as efifb or vesafb. I think removing those without replacing the console will cause the console to stop working completely.

I have a series of changes to add support for framebuffer consoles, similar to #342 but integrated with the rest of the driver. In that change, the driver calls drm_aperture_remove_conflicting_pci_framebuffers only if it is installing its own framebuffer console. I'll close this pull request once a driver with those changes is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants