Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang version to 1.22.2 #53

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Bump golang version to 1.22.2 #53

merged 4 commits into from
Apr 18, 2024

Conversation

tariq1890
Copy link
Contributor

No description provided.

@tariq1890 tariq1890 changed the title bump cuda base image version to 12.4.2 bump cuda base image version to 12.4.1 Apr 11, 2024
@tariq1890 tariq1890 requested a review from klueska April 11, 2024 22:57
@tariq1890 tariq1890 changed the title bump cuda base image version to 12.4.1 bump cuda base image version to 12.4.2 and go to 1.22.2 Apr 11, 2024
versions.mk Outdated Show resolved Hide resolved
elezar
elezar previously requested changes Apr 12, 2024
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to the 12.4.2 version string.

Also, please separate the two changes into two commits.

@elezar
Copy link
Member

elezar commented Apr 12, 2024

In order to reduce the future burden, let's rather enable dependabot updates for CUDA base images in this repo.

@elezar
Copy link
Member

elezar commented Apr 12, 2024

In order to reduce the future burden, let's rather enable dependabot updates for CUDA base images in this repo.

@tariq1890 I created #54 for the dependabot rule and related changes. Does it make sense to merge that first and then rebase this one to only include the go version bump?

@tariq1890
Copy link
Contributor Author

@elezar Sounds good to me!

@elezar elezar dismissed their stale review April 18, 2024 08:12

Changes made.

@elezar elezar changed the title bump cuda base image version to 12.4.2 and go to 1.22.2 Bump golang version to 1.22.2 Apr 18, 2024
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

I rebased and ran mod tidy.

@elezar elezar merged commit 83a006c into main Apr 18, 2024
6 checks passed
@elezar elezar deleted the bump-cuda-base branch April 18, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants