ESM2 Infer partial batches using predict method #304
+31
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farhadrgh
added
the
bug_fix_for_v24.10
jstjohn
approved these changes
Oct 11, 2024
|
Also see #302 which bumps the nemo version, is it new enough for your needs? |
|
/build-ci |
farhadrgh
added
NOT_related_to_v24.10
and removed
bug_fix_for_v24.10
farhadrgh
requested review from
malcolmgreaves,
ohadmo and
trvachov
as code owners
|
The NVIDIA/NeMo#10934 has overridden the changes to expose CC @jstjohn |
|
/build-ci |
farhadrgh
changed the title
pstjohn
approved these changes
Oct 30, 2024
|
|
/build-ci |
…IA/bionemo-framework into farhadr/infer_partial_batch
|
/build-ci |
|
/build-ci |
|
/build-ci |
1 similar comment
|
/build-ci |
|
/build-ci |
1 similar comment
|
/build-ci |
|
/build-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on changes in NVIDIA/NeMo#10837 to expose
drop_lastinMegatronDataSamplerand allow inference of partial batches.Note:
The NVIDIA/NeMo#10934 has overridden the changes to expose drop_last. We should now wrap dataloaders with nemo.lightning.data.WrappedDataLoader that can store the mode attribute when creating the dataloader in datamodules. Then drop_last=False if dataloader is in test or predict mode.