Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Common] Moved framework agnostic THD kernels to common. #1339

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mgoldfarb-nvidia
Copy link
Collaborator

Description

Moves several kernels that are used for context parallelism + THD fused attention to shared location so they can be called by Jax and other frameworks.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Moves common code out of pytorch filder.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@mgoldfarb-nvidia mgoldfarb-nvidia force-pushed the mgoldfarb/move_thd_fused_attn_utils_to_common branch from 94a75ac to 81718ac Compare November 15, 2024 22:12
@mgoldfarb-nvidia mgoldfarb-nvidia force-pushed the mgoldfarb/move_thd_fused_attn_utils_to_common branch 3 times, most recently from 95bcc57 to 685ad1b Compare November 15, 2024 22:19
@mgoldfarb-nvidia mgoldfarb-nvidia force-pushed the mgoldfarb/move_thd_fused_attn_utils_to_common branch from 685ad1b to 3ee113e Compare November 15, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant