Batch inference for sam2 image pipeline #382
Open
+131
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yizhuoz004
force-pushed
the
sam2-image-multi-batch
branch
from
cd3d9bb
to
885c372
Compare
parthchadha
reviewed
Nov 16, 2024
| @@ -174,19 +174,22 @@ def main(image_path: str, save_path: Optional[str] = None): | |||
| # Create predictor and process image | |||
| predictor = SAM2ImagePredictor(sam2_model) | |||
|
|
|||
| predictor.set_image(image) | |||
| predictor.set_image_batch([image, image]) | |||
There was a problem hiding this comment.
I think we should an option to run batch N inference and not always batch = 2
parthchadha
reviewed
Nov 16, 2024
| box, | ||
| mask_input, | ||
| normalize_coords, | ||
| # assuming all images in the batch have the same size |
There was a problem hiding this comment.
Let's add an assertion for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.