Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nemo run ipl #11910

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from
Draft

Nemo run ipl #11910

wants to merge 34 commits into from

Conversation

nune-tadevosyan
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

titu1994 and others added 30 commits October 28, 2024 15:10
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module run_helper
examples/asr/run_helper.py:32:0: C0301: Line too long (113/100) (line-too-long)
examples/asr/run_helper.py:33:0: C0301: Line too long (106/100) (line-too-long)
examples/asr/run_helper.py:41:0: C0301: Line too long (115/100) (line-too-long)
examples/asr/run_helper.py:52:0: C0301: Line too long (119/100) (line-too-long)
examples/asr/run_helper.py:62:0: C0301: Line too long (119/100) (line-too-long)
examples/asr/run_helper.py:63:0: C0301: Line too long (112/100) (line-too-long)
examples/asr/run_helper.py:91:0: C0301: Line too long (112/100) (line-too-long)
examples/asr/run_helper.py:129:0: C0301: Line too long (113/100) (line-too-long)
examples/asr/run_helper.py:145:0: C0301: Line too long (137/100) (line-too-long)
examples/asr/run_helper.py:179:0: C0301: Line too long (103/100) (line-too-long)
examples/asr/run_helper.py:187:0: C0301: Line too long (108/100) (line-too-long)
examples/asr/run_helper.py:192:0: C0301: Line too long (101/100) (line-too-long)
examples/asr/run_helper.py:200:0: C0301: Line too long (124/100) (line-too-long)
examples/asr/run_helper.py:225:0: C0301: Line too long (144/100) (line-too-long)
examples/asr/run_helper.py:228:0: C0301: Line too long (102/100) (line-too-long)
examples/asr/run_helper.py:235:0: C0301: Line too long (114/100) (line-too-long)
examples/asr/run_helper.py:257:0: C0301: Line too long (104/100) (line-too-long)
examples/asr/run_helper.py:276:0: C0301: Line too long (137/100) (line-too-long)
examples/asr/run_helper.py:281:0: C0301: Line too long (116/100) (line-too-long)
examples/asr/run_helper.py:296:0: C0301: Line too long (112/100) (line-too-long)
examples/asr/run_helper.py:304:0: C0301: Line too long (108/100) (line-too-long)
examples/asr/run_helper.py:305:0: C0301: Line too long (104/100) (line-too-long)
examples/asr/run_helper.py:306:0: C0301: Line too long (111/100) (line-too-long)
examples/asr/run_helper.py:312:0: C0301: Line too long (109/100) (line-too-long)
examples/asr/run_helper.py:314:0: C0301: Line too long (101/100) (line-too-long)
examples/asr/run_helper.py:365:0: C0301: Line too long (105/100) (line-too-long)
examples/asr/run_helper.py:395:0: C0301: Line too long (131/100) (line-too-long)
examples/asr/run_helper.py:428:0: C0301: Line too long (110/100) (line-too-long)
examples/asr/run_helper.py:431:0: C0301: Line too long (101/100) (line-too-long)
examples/asr/run_helper.py:1:0: C0114: Missing module docstring (missing-module-docstring)
examples/asr/run_helper.py:20:0: E0401: Unable to import 'nemo_run' (import-error)
examples/asr/run_helper.py:21:0: E0401: Unable to import 'omegaconf' (import-error)
examples/asr/run_helper.py:172:16: C0415: Import outside toplevel (aistore.sdk.Client) (import-outside-toplevel)
examples/asr/run_helper.py:183:16: W0612: Unused variable 'k' (unused-variable)
examples/asr/run_helper.py:349:0: C0116: Missing function or method docstring (missing-function-docstring)
examples/asr/run_helper.py:349:0: R0914: Too many local variables (28/15) (too-many-locals)
examples/asr/run_helper.py:349:0: R0915: Too many statements (68/50) (too-many-statements)
examples/asr/run_helper.py:484:4: E1120: No value for argument 'cluster_cfg' in function call (no-value-for-parameter)
examples/asr/run_helper.py:18:0: W0611: Unused List imported from typing (unused-import)
************* Module nemo.collections.asr.models.hybrid_rnnt_ctc_bpe_models
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:33:0: C0301: Line too long (102/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:41:0: C0301: Line too long (116/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:77:0: C0301: Line too long (107/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:88:0: C0301: Line too long (106/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:192:0: C0301: Line too long (105/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:219:0: C0301: Line too long (114/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:264:0: C0301: Line too long (121/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:265:0: C0301: Line too long (120/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:266:0: C0301: Line too long (117/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:270:0: C0301: Line too long (123/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:273:0: C0301: Line too long (106/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:274:0: C0301: Line too long (129/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:284:0: C0301: Line too long (139/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:294:0: C0301: Line too long (110/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:355:0: C0301: Line too long (105/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:370:0: C0301: Line too long (101/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:408:0: C0301: Line too long (103/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:424:0: C0301: Line too long (110/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:431:0: C0301: Line too long (106/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:432:0: C0301: Line too long (104/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:433:0: C0301: Line too long (106/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:434:0: C0301: Line too long (105/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:439:0: C0301: Line too long (111/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:465:0: C0301: Line too long (109/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:477:0: C0301: Line too long (118/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:481:0: C0301: Line too long (118/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:484:0: C0301: Line too long (111/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:509:0: C0301: Line too long (115/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:512:0: C0301: Line too long (107/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:517:0: C0301: Line too long (115/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:526:0: C0301: Line too long (156/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:527:0: C0301: Line too long (173/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:533:0: C0301: Line too long (156/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:534:0: C0301: Line too long (173/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:540:0: C0301: Line too long (156/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:541:0: C0301: Line too long (173/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:547:0: C0301: Line too long (156/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:548:0: C0301: Line too long (173/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:554:0: C0301: Line too long (156/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:555:0: C0301: Line too long (190/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:561:0: C0301: Line too long (156/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:562:0: C0301: Line too long (173/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:568:0: C0301: Line too long (156/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:569:0: C0301: Line too long (173/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:575:0: C0301: Line too long (156/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:576:0: C0301: Line too long (173/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:582:0: C0301: Line too long (156/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:583:0: C0301: Line too long (173/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:589:0: C0301: Line too long (156/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:590:0: C0301: Line too long (173/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:596:0: C0301: Line too long (175/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:597:0: C0301: Line too long (211/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:603:0: C0301: Line too long (166/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:604:0: C0301: Line too long (193/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:610:0: C0301: Line too long (168/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:611:0: C0301: Line too long (197/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:617:0: C0301: Line too long (169/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:618:0: C0301: Line too long (199/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:624:0: C0301: Line too long (170/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:625:0: C0301: Line too long (201/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:631:0: C0301: Line too long (169/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:632:0: C0301: Line too long (199/100) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:1:0: C0114: Missing module docstring (missing-module-docstring)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:19:0: E0401: Unable to import 'torch' (import-error)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:20:0: E0401: Unable to import 'omegaconf' (import-error)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:21:0: E0401: Unable to import 'pytorch_lightning' (import-error)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:40:0: R0901: Too many ancestors (20/7) (too-many-ancestors)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:40:0: R0902: Too many instance attributes (11/7) (too-many-instance-attributes)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:88:16: C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:141:8: R1720: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it (no-else-raise)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:241:27: W0212: Access to a protected member _sample_rate of a client class (protected-access)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:256:4: W0237: Parameter 'new_vocabulary' has been renamed to 'new_tokenizer_dir' in overriding 'EncDecHybridRNNTCTCBPEModel.change_vocabulary' method (arguments-renamed)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:256:4: W0237: Parameter 'decoding_cfg' has been renamed to 'new_tokenizer_type' in overriding 'EncDecHybridRNNTCTCBPEModel.change_vocabulary' method (arguments-renamed)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:256:4: W0237: Parameter 'ctc_decoding_cfg' has been renamed to 'decoding_cfg' in overriding 'EncDecHybridRNNTCTCBPEModel.change_vocabulary' method (arguments-renamed)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:256:4: R0914: Too many local variables (16/15) (too-many-locals)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:298:33: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:384:16: C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:256:4: R0912: Too many branches (16/12) (too-many-branches)
nemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:256:4: R0915: Too many statements (77/50) (too-many-statements)
************* Module nemo.collections.common.parts.run_utils
nemo/collections/common/parts/run_utils.py:63:0: C0301: Line too long (108/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:73:0: C0301: Line too long (121/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:84:0: C0301: Line too long (121/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:101:0: C0301: Line too long (116/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:145:0: C0301: Line too long (105/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:148:0: C0301: Line too long (115/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:194:0: C0301: Line too long (115/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:199:0: C0301: Line too long (109/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:201:0: C0301: Line too long (105/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:230:0: C0301: Line too long (104/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:254:0: C0301: Line too long (104/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:264:0: C0301: Line too long (109/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:269:0: C0301: Line too long (111/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:271:0: C0301: Line too long (110/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:272:0: C0301: Line too long (114/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:273:0: C0301: Line too long (106/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:275:0: C0301: Line too long (128/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:279:0: C0301: Line too long (106/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:281:0: C0301: Line too long (129/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:307:0: C0301: Line too long (116/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:324:0: C0301: Line too long (116/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:330:0: C0301: Line too long (112/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:335:0: C0301: Line too long (108/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:338:0: C0301: Line too long (113/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:356:0: C0301: Line too long (104/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:391:0: C0301: Line too long (104/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:416:0: C0301: Line too long (105/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:436:0: C0301: Line too long (102/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:442:0: C0301: Line too long (112/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:449:0: C0301: Line too long (110/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:469:0: C0301: Line too long (102/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:475:0: C0301: Line too long (112/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:507:0: C0301: Line too long (101/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:513:0: C0301: Line too long (105/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:525:0: C0301: Line too long (109/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:592:0: C0301: Line too long (106/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:672:0: C0301: Line too long (104/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:725:0: C0301: Line too long (115/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:727:0: C0301: Line too long (117/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:734:0: C0301: Line too long (102/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:770:0: C0301: Line too long (114/100) (line-too-long)
nemo/collections/common/parts/run_utils.py:1:0: C0114: Missing module docstring (missing-module-docstring)
nemo/collections/common/parts/run_utils.py:25:0: E0401: Unable to import 'nemo_run' (import-error)
nemo/collections/common/parts/run_utils.py:26:0: E0401: Unable to import 'nemo_run.config' (import-error)
nemo/collections/common/parts/run_utils.py:27:0: E0401: Unable to import 'nemo_run.core.execution.docker' (import-error)
nemo/collections/common/parts/run_utils.py:28:0: E0401: Unable to import 'nemo_run.core.execution.slurm' (import-error)
nemo/collections/common/parts/run_utils.py:29:0: E0401: Unable to import 'nemo_run.core.serialization.zlib_json' (import-error)
nemo/collections/common/parts/run_utils.py:30:0: E0401: Unable to import 'nemo_run.core.tunnel' (import-error)
nemo/collections/common/parts/run_utils.py:31:0: E0401: Unable to import 'omegaconf' (import-error)
nemo/collections/common/parts/run_utils.py:38:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/common/parts/run_utils.py:59:4: C0200: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)
nemo/collections/common/parts/run_utils.py:42:49: W0613: Unused argument 'env_vars' (unused-argument)
nemo/collections/common/parts/run_utils.py:290:4: C0200: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)
nemo/collections/common/parts/run_utils.py:330:0: R0912: Too many branches (13/12) (too-many-branches)
nemo/collections/common/parts/run_utils.py:539:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/common/parts/run_utils.py:545:9: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
nemo/collections/common/parts/run_utils.py:562:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/common/parts/run_utils.py:566:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/common/parts/run_utils.py:570:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/common/parts/run_utils.py:574:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/common/parts/run_utils.py:578:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/common/parts/run_utils.py:598:0: R0913: Too many arguments (11/5) (too-many-arguments)
nemo/collections/common/parts/run_utils.py:598:0: R0917: Too many positional arguments (11/5) (too-many-positional-arguments)
nemo/collections/common/parts/run_utils.py:684:20: E1123: Unexpected keyword argument 'job_name' in constructor call (unexpected-keyword-arg)
nemo/collections/common/parts/run_utils.py:684:20: E1123: Unexpected keyword argument 'folder' in constructor call (unexpected-keyword-arg)
nemo/collections/common/parts/run_utils.py:697:0: R0913: Too many arguments (12/5) (too-many-arguments)
nemo/collections/common/parts/run_utils.py:697:0: R0917: Too many positional arguments (12/5) (too-many-positional-arguments)
nemo/collections/common/parts/run_utils.py:697:0: R0914: Too many local variables (16/15) (too-many-locals)
nemo/collections/common/parts/run_utils.py:783:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/common/parts/run_utils.py:19:0: W0611: Unused import subprocess (unused-import)

-----------------------------------
Your code has been rated at 6.66/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

Copy link
Contributor

beep boop 🤖: 🚨 The following files must be fixed before merge!


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module run_update_inf_config
examples/asr/run_update_inf_config.py:33:0: C0301: Line too long (102/100) (line-too-long)
examples/asr/run_update_inf_config.py:59:0: C0301: Line too long (102/100) (line-too-long)
examples/asr/run_update_inf_config.py:91:0: C0301: Line too long (118/100) (line-too-long)
examples/asr/run_update_inf_config.py:109:0: C0301: Line too long (106/100) (line-too-long)
examples/asr/run_update_inf_config.py:1:0: C0114: Missing module docstring (missing-module-docstring)
examples/asr/run_update_inf_config.py:19:0: E0401: Unable to import 'torch.distributed' (import-error)
examples/asr/run_update_inf_config.py:20:0: E0401: Unable to import 'omegaconf' (import-error)
examples/asr/run_update_inf_config.py:38:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
examples/asr/run_update_inf_config.py:52:7: R1701: Consider merging these isinstance calls to isinstance(manifest_filepath, (OmegaConf.ListConfig, list)) (consider-merging-isinstance)
examples/asr/run_update_inf_config.py:54:9: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
examples/asr/run_update_inf_config.py:101:0: C0116: Missing function or method docstring (missing-function-docstring)
examples/asr/run_update_inf_config.py:107:0: C0116: Missing function or method docstring (missing-function-docstring)
************* Module run_write_transcribed_files
examples/asr/run_write_transcribed_files.py:27:0: C0301: Line too long (103/100) (line-too-long)
examples/asr/run_write_transcribed_files.py:29:0: C0301: Line too long (102/100) (line-too-long)
examples/asr/run_write_transcribed_files.py:30:0: C0301: Line too long (103/100) (line-too-long)
examples/asr/run_write_transcribed_files.py:39:0: C0301: Line too long (111/100) (line-too-long)
examples/asr/run_write_transcribed_files.py:57:0: C0301: Line too long (104/100) (line-too-long)
examples/asr/run_write_transcribed_files.py:139:0: C0301: Line too long (102/100) (line-too-long)
examples/asr/run_write_transcribed_files.py:154:0: C0301: Line too long (109/100) (line-too-long)
examples/asr/run_write_transcribed_files.py:165:0: C0301: Line too long (119/100) (line-too-long)
examples/asr/run_write_transcribed_files.py:233:0: C0301: Line too long (103/100) (line-too-long)
examples/asr/run_write_transcribed_files.py:234:0: C0301: Line too long (106/100) (line-too-long)
examples/asr/run_write_transcribed_files.py:1:0: C0114: Missing module docstring (missing-module-docstring)
examples/asr/run_write_transcribed_files.py:20:0: E0401: Unable to import 'torch.distributed' (import-error)
examples/asr/run_write_transcribed_files.py:47:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
examples/asr/run_write_transcribed_files.py:51:16: R1731: Consider using 'max_shard_id = max(max_shard_id, shard_id)' instead of unnecessary if block (consider-using-max-builtin)
examples/asr/run_write_transcribed_files.py:58:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
examples/asr/run_write_transcribed_files.py:112:0: R0914: Too many local variables (16/15) (too-many-locals)
examples/asr/run_write_transcribed_files.py:132:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
examples/asr/run_write_transcribed_files.py:139:44: W0631: Using possibly undefined loop variable 'prediction_filepath' (undefined-loop-variable)
examples/asr/run_write_transcribed_files.py:141:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
examples/asr/run_write_transcribed_files.py:148:39: W0631: Using possibly undefined loop variable 'prediction_filepath' (undefined-loop-variable)
examples/asr/run_write_transcribed_files.py:149:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
examples/asr/run_write_transcribed_files.py:165:43: W0631: Using possibly undefined loop variable 'prediction_filepath' (undefined-loop-variable)
examples/asr/run_write_transcribed_files.py:191:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
examples/asr/run_write_transcribed_files.py:199:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
examples/asr/run_write_transcribed_files.py:205:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
examples/asr/run_write_transcribed_files.py:223:0: C0116: Missing function or method docstring (missing-function-docstring)
examples/asr/run_write_transcribed_files.py:229:0: C0116: Missing function or method docstring (missing-function-docstring)
************* Module nemo.collections.common.parts.run_ipl_utils
nemo/collections/common/parts/run_ipl_utils.py:41:0: C0301: Line too long (108/100) (line-too-long)
nemo/collections/common/parts/run_ipl_utils.py:60:0: C0301: Line too long (110/100) (line-too-long)
nemo/collections/common/parts/run_ipl_utils.py:95:0: C0301: Line too long (116/100) (line-too-long)
nemo/collections/common/parts/run_ipl_utils.py:124:0: C0301: Line too long (109/100) (line-too-long)
nemo/collections/common/parts/run_ipl_utils.py:133:0: C0301: Line too long (107/100) (line-too-long)
nemo/collections/common/parts/run_ipl_utils.py:1:0: C0114: Missing module docstring (missing-module-docstring)
nemo/collections/common/parts/run_ipl_utils.py:18:0: E0401: Unable to import 'omegaconf' (import-error)
nemo/collections/common/parts/run_ipl_utils.py:38:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
nemo/collections/common/parts/run_ipl_utils.py:38:11: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck)

-----------------------------------
Your code has been rated at 7.43/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

import os
from pathlib import Path
from typing import Dict, List

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'List' is not used.
)
checkpoint_name = os.path.join(checkpoint_dir, merged_config.exp_manager.name + ".nemo")
inference_config_paths, manifests, tarr_paths = run_utils.create_remote_inference_config(
cluster_cfg, config_dir, inference_config, checkpoint_name

Check failure

Code scanning / CodeQL

Potentially uninitialized local variable Error

Local variable 'inference_config' may be used before it is initialized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants