build: Add conda env to $PATH (#357)

* build: Add conda env to `$PATH`

Signed-off-by: Oliver Koenig <[email protected]>

* test

Signed-off-by: Oliver Koenig <[email protected]>

* add newline

Signed-off-by: Oliver Koenig <[email protected]>

* run cleanup always

Signed-off-by: Oliver Koenig <[email protected]>

---------

Signed-off-by: Oliver Koenig <[email protected]>

.github/workflows/gpuci.yml

@@ -70,19 +70,20 @@ jobs:
       # list all of our packages. Useful for debugging
     - name: Verify installations
       run: |
-        docker exec nemo-curator-container conda run -n curator pip list
+        docker exec nemo-curator-container pip list
 
       # In the virtual environment (called "curator") we created in the container,
       # run our PyTests marked with `@pytest.mark.gpu`
       # We specify the `rootdir` to help locate the "pyproject.toml" file (which is in the root directory of the repository),
       # and then the directory where the PyTests are located
     - name: Run PyTests with GPU mark
       run: |
-        docker exec nemo-curator-container conda run -n curator pytest -m gpu --rootdir /opt/NeMo-Curator /opt/NeMo-Curator/tests
+        docker exec nemo-curator-container pytest -m gpu --rootdir /opt/NeMo-Curator /opt/NeMo-Curator/tests
 
       # After running `docker stop`, the container remains in an exited state
       # It is still present on our system and could be restarted with `docker start`
       # Thus, we use `docker rm` to permanently removed it from the system
     - name: Cleanup
+      if: always()
       run: |
         docker stop nemo-curator-container && docker rm nemo-curator-container

Dockerfile

@@ -53,3 +53,5 @@ RUN bash -exu <<EOF
   cd /opt/NeMo-Curator/
   pip install --extra-index-url https://pypi.nvidia.com ".[all]"
 EOF
+
+ENV PATH /opt/conda/envs/curator/bin:$PATH