Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades certifi in jax image to address CVE https://github.com/advisories/GHSA-xqr8-7jwr-rhp7 #210

Closed
wants to merge 1 commit into from

Conversation

terrykong
Copy link
Contributor

No description provided.

@terrykong
Copy link
Contributor Author

Closing since this actually isn't an issue b/c all certifi constraints are open-ended (>=YYYY.MM.DD) so our latest nightlies should automatically get the latest version.

@terrykong terrykong closed this Sep 6, 2023
@nouiz
Copy link
Collaborator

nouiz commented Sep 7, 2023

Closing since this actually isn't an issue b/c all certifi constraints are open-ended (>=YYYY.MM.DD) so our latest nightlies should automatically get the latest version.

I don't like the word "should". Can you download the latest container and check the version in it? Is it recent enough to have that CVE fixed with it?

@nouiz nouiz reopened this Sep 7, 2023
@terrykong
Copy link
Contributor Author

Here's yesterday's nightly that has an acceptable version installed:

terryk@joc-sc-ws-005:~$ docker run --entrypoint='' --rm -it ghcr.io/nvidia/pax:nightly-2023-09-06 pip show certifi
Name: certifi
Version: 2023.7.22
Summary: Python package for providing Mozilla's CA Bundle.
Home-page: https://github.com/certifi/python-certifi
Author: Kenneth Reitz
Author-email: [email protected]
License: MPL-2.0
Location: /usr/local/lib/python3.10/dist-packages
Requires:
Required-by: requests

I shouldn't have said "should". To be more precise. We will install a good version of certifi, unless a new package is introduced that pins it and downgrades it.

@nouiz
Copy link
Collaborator

nouiz commented Sep 7, 2023

SG.

@nouiz nouiz closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants