Connect AWS/P5 (H100) instances to CI #1133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make use of _test_slurm_pyxis.yaml a little less verbose, and add a new GPU_TYPE input to it. Also change the default to non-exclusive allocation, with exclusive allocation available on request.
olupton
force-pushed
the
olupton/aws-ci
branch
from
2e63996
to
84527cc
Compare
mjsML
requested changes
Oct 31, 2024
yhtang
requested changes
Nov 6, 2024
| @@ -2,29 +2,11 @@ name: ~test multi-node jobs via SLURM+Pyxis | |||
|
|
|||
| on: | |||
| workflow_call: | |||
| secrets: | |||
There was a problem hiding this comment.
Why would you remove it? It will make the workflow less adaptable to more clusters.
| run-test: | ||
| name: ${{ inputs.NAME }} | ||
| runs-on: jumpbox | ||
| env: | ||
| OUTPUT_BASEDIR: /nfs/cluster | ||
| SLURM_CLUSTER: ${{ inputs.GPU_TYPE == 'A100' && secrets.CLUSTER_LOGIN_USER || secrets.AWS_LOGIN_USER }}@${{ inputs.GPU_TYPE == 'A100' && vars.HOSTNAME_SLURM_LOGIN || vars.HOSTNAME_AWS_SLURM }} |
There was a problem hiding this comment.
This logic, if necessary, shall be better placed in the calling workflow to maximize reusability of this workflow (which is essentially a function to be called by the master workflow).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of _test_slurm_pyxis.yaml a little less verbose, and add a new GPU_TYPE input to it. Also change the default to non-exclusive allocation, with exclusive allocation available on request.