disable goodput recorder in test-maxtest.sh #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpupuck
previously approved these changes
Oct 16, 2024
terrykong
reviewed
Oct 16, 2024
Signed-off-by: Md Fahim Faysal Khan <[email protected]>
gpupuck
approved these changes
Oct 16, 2024
terrykong
approved these changes
Oct 16, 2024
|
Thanks for the quick fix! Approved modulo tests passing |
nouiz
reviewed
Oct 20, 2024
| @@ -245,22 +245,58 @@ RUN_NAME="logdir" ## the RUN_NAME cannot be changed | |||
| if [ -z "$DECODER_BLOCK" ]; then | |||
There was a problem hiding this comment.
@kocchop
instead of if [ -z "$DECODER_BLOCK" ]; then ...
It could be something like:
RUN_SETTINGS="MaxText/train.py \
MaxText/configs/base.yml \
run_name=${RUN_NAME} \
${DECODER_ARG} \
....
This remove the duplicate code and make clear this is the only different in both condition.
Right now, it isn't clear if there is other diff then this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goodput recorder was turned off by default and we do not use it. However, it has been turned on by default from MaxText side 2 days ago which is breaking the CI tests. We just need to explicitly disable these whenever we're running.