Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow additional args to be passed many times #1102

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

gpupuck
Copy link
Contributor

@gpupuck gpupuck commented Oct 15, 2024

This would allow

-a "scan_layers=false max_target_length=4096 use_iota_embed=true logits_dot_in_fp32=false"

to be

-a scan_layers=false 
-a max_target_length=4096 
-a use_iota_embed=true 
-a logits_dot_in_fp32=false

It will help avoid issues if quotes are not present during string interpolation.

@gpupuck gpupuck requested a review from kocchop October 15, 2024 17:22
@kocchop
Copy link
Contributor

kocchop commented Oct 15, 2024

@gpupuck all the maxtext CI tests are failing

@kocchop kocchop merged commit ddec4bd into main Oct 16, 2024
163 of 174 checks passed
@kocchop kocchop deleted the by/many-additional-args branch October 16, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants