Skip to content

Commit

Permalink
Pin IPython version to 8.2 (#879)
Browse files Browse the repository at this point in the history
Gemma container installs `jupyterlab` package to run a jupyter-notebook
example. Unfortunately, the latest version of `IPython`(8.23) requires
`typing-extension` of 4.6.1 or higher, which creates conflict with
installed version of `typing-extension` (4.5.0 required by tensorflow).
The solution is to ping `IPython` to 8.2.
  • Loading branch information
DwarKapex authored Jun 10, 2024
1 parent 0005642 commit 98a30fe
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/_ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ jobs:
EXECUTE: |
docker run --shm-size=1g --gpus all ${{ needs.build-gemma.outputs.DOCKER_TAG_FINAL }} \
bash -ec \
"cd /opt/gemma && pip install -e .[test] && pytest . && python /opt/gemma/tests/test_paligemma.py" | tee test-gemma.log
"cd /opt/gemma && pip install -e .[test] && pytest ." | tee test-gemma.log
STATISTICS_SCRIPT: |
summary_line=$(tail -n1 test-gemma.log)
errors=$(echo $summary_line | grep -oE '[0-9]+ error' | awk '{print $1} END { if (!NR) print 0}')
Expand Down
3 changes: 2 additions & 1 deletion rosetta/Dockerfile.gemma
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ echo "-e file://${SRC_PATH_GEMMA}" >> /opt/pip-tools.d/requirements-gemma.in
echo "-e file://${SRC_PATH_COMMON_LOOP_UTILS}" >> /opt/pip-tools.d/requirements-gemma.in
echo "-e file://${SRC_PATH_FLAXFORMER}" >> /opt/pip-tools.d/requirements-gemma.in
echo "-e file://${SRC_PATH_PANOPTICAPI}" >> /opt/pip-tools.d/requirements-gemma.in
echo "jupyterlab
echo "ipython==8.2
jupyterlab
gcloud
overrides
ml_collections
Expand Down

0 comments on commit 98a30fe

Please sign in to comment.