Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tagset support for select-by-tag #86

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add tagset support for select-by-tag #86

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ab1831
add tagset support for select-by-tag
jperez999 May 6, 2022
4ee61b6
Merge branch 'main' into fix-select-tag
karlhigley Aug 15, 2022
349d22d
Merge branch 'main' into fix-select-tag
karlhigley Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions merlin/schema/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,9 @@ def excluding(self, selector) -> "Schema":
def apply_inverse(self, selector) -> "Schema":
return self.excluding(selector)

def select_by_tag(self, tags: Union[Union[str, Tags], List[Union[str, Tags]]]) -> "Schema":
def select_by_tag(
self, tags: Union[Union[str, Tags], List[Union[str, Tags]], TagSet]
) -> "Schema":
"""Select matching columns from this Schema object using a list of tags

Parameters
Expand All @@ -299,8 +301,11 @@ def select_by_tag(self, tags: Union[Union[str, Tags], List[Union[str, Tags]]]) -
New object containing only the ColumnSchemas of selected columns

"""
if not isinstance(tags, (list, tuple)):
if isinstance(tags, tuple):
tags = list(tags)
if not isinstance(tags, list):
tags = [tags]
tags = TagSet(tags)

selected_schemas = {}

Expand Down