nav bar codes #26
Merged
nav bar codes #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @rachelsitoh , when importing the navbars to index page, i get these errors, can you help to fix them? thx! |
gnimnix
approved these changes
Mar 14, 2024
gnimnix
requested changes
Mar 14, 2024
|
|
Use the useClickAway hook for click away behaviour |
…TAS-12-nav-bar # Conflicts: # package.json # public/fintech_logo.png # public/material-symbols_close.png # public/person_logo.png # src/assets/css/App.css # src/routes/shared/TestPage.tsx # yarn.lock
gnimnix
requested changes
Mar 25, 2024
| const profileOptionsRef = useClickAway(() => { | ||
| setShowProfileOptions(false); | ||
| }); | ||
|
|
There was a problem hiding this comment.
@rachelsitoh , I think the click behaviour feels kinda weird, could u change to dropdown on hover? so remove this clickaway hook and make it display on hover, should only need css, thx!
gnimnix
reviewed
Mar 25, 2024
gnimnix
approved these changes
May 19, 2024
gnimnix
merged commit 2a04a85
into
epic/DEV-4-shared-components-and-layouts
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Nav bar for desktop and mobile
Related Issues
[Reference any related issues that this pull request addresses or resolves.]
Checklist
Please review and check the following before submitting your pull request:
Desktop
Mobile
Additional Information
I assumed clicking on the profile logo will make the 'box' containing profile and sign out appear, and clicking it again will remove the 'box'. (For desktop, clicking on the white areas outside the header will make the 'box' disappear). lmk if any changes are needed. Also, I assume that clicking on the fintech logo will route to /