Write area detectors to proposal directories #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cycle = '2023-3' # TODO: don't hardcode this | ||
|
|
||
| proposal_dir = f"/nsls2/data/chx/proposals/{cycle}/{data_session}" | ||
| Path(proposal_dir).mkdir(parents=True, exist_ok=True) |
There was a problem hiding this comment.
This Python process will never have permission to make directories here. You can assume the directory has been created.
| eiger500k_single.file.write_path_template = '/nsls2/data/chx/assets/eiger500k/%Y/%m/%d/' | ||
| eiger500k_single.file.reg_root ='/nsls2/data/chx/assets/eiger500k/' | ||
| eiger500k_single.file.write_path_template = f'{proposal_dir}/assets/eiger500k/%Y/%m/%d/' | ||
| eiger500k_single.file.reg_root =f'{proposal_dir}/assets/eiger500k/' |
There was a problem hiding this comment.
Have you considered making it assets_dir? That would make it harder to accidentally write into the top-level proposals dir (where users have access to move and delete things).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the format
/nsls2/data/chx/proposals/{cycle}/{data_session}/assets