-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bnb/training with obs #252
Draft
bnb32
wants to merge
25
commits into
main
Choose a base branch
from
bnb/training_with_obs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+2,085
−1,126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et to work with three data members.
…orbed WithObs variant.
…ind model training added to examples README.
bnb32
force-pushed
the
bnb/training_with_obs
branch
from
December 27, 2024 16:41
6c036e0
to
b1cb942
Compare
…`` class to enable passing ``xr.Dataset`` and like objects directly to ``BatchHandlers`` without needing to invoke ``.data``
…b/training_with_obs
…ueueing, since batches can be sampled directly if there are none in the queue).
bnb32
force-pushed
the
bnb/training_with_obs
branch
from
December 29, 2024 23:45
ee31120
to
046a279
Compare
…d dequeueing since this would cast to tensors.
bnb32
force-pushed
the
bnb/training_with_obs
branch
from
December 30, 2024 00:12
046a279
to
f6f3e40
Compare
…h ``max_workers > 1``.
… just sampling is, except for macos, but training is not.
bnb32
force-pushed
the
bnb/training_with_obs
branch
from
January 2, 2025 20:05
bd493b1
to
7897998
Compare
bnb32
force-pushed
the
bnb/training_with_obs
branch
from
January 3, 2025 23:11
2b9c0d0
to
e1ee79a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added observation member to
Sup3rDataset
and minor modifications to samplers / batch queues to enable additional observation based loss term in training. Split sampling and enqueuing in batch handling which seems to have at least partially resolved the max_workers > 1 issue.