Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geothermal loop & soil properties: baseline #1134

Closed
wants to merge 20 commits into from

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Sep 7, 2023

Pull Request Description

Update options_lookup.tsv to assign site_ground_conductivity based on "ASHRAE IECC Climate Zone 2004".

New cost multipliers in results.csv:

  • upgrade_costs.depth_geothermal_loop_boreholes_ft
  • upgrade_costs.flow_rate_geothermal_loop_gpm
  • upgrade_costs.number_geothermal_loop_boreholes_count

Checklist

Not all may apply:

@@ -1,17 +1,18 @@
schema_version: '0.3'
os_version: 3.6.1
os_sha: bb9481519e
os_version: 3.5.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prsh5175 Hmm, I don't think we need to be touching this file...? I think we can create the precomputed buildstock.csv file using national_upgrades_gshp.yml.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Forgot to undo/ignore this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants