-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Emissions to Latest Data #460
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good I just had a couple questions with one maybe todo
"lifetime" => string(lifetime), # Integer 1 or greater (Default 25 yrs) | ||
"discount_rate" => "0.0", # Zero = simple average (a pwf with discount rate gets applied to projected CO2 costs, but not quantity.) | ||
"time_type" => "hourly", # hourly or annual | ||
"metric_col" => metric_col, # lrmer_co2e | ||
"smoothing_method" => "rolling", # rolling or none (only applicable to hourly queries). "rolling" best with TMY data; "none" best if 2012 weather data used. | ||
"gwp" => "100yrAR6", # Global warming potential values. Default: "100yrAR6". Options: "100yrAR5", "20yrAR5", "100yrAR6", "20yrAR6" or a custom tuple [1,10.0,100] with GWP values for [CO2, CH4, N2O] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be reverted before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh great catch. I don't think this necessarily needs to be reverted because [1, 29.8, 273.0] should == using "100yrAR6". However, it would be good to find out if "100yrAR6" is still a viable option (currently, it errors). I'm still waiting to hear back from the Cambium team on this so let's keep this as an open TODO.
@test !haskey(results, "Generator") | ||
# Renewable energy | ||
@test results["Site"]["renewable_electricity_fraction"] ≈ 0.78586 atol=1e-3 | ||
@test results["Site"]["renewable_electricity_fraction"] ≈ 0.745 rtol=0.01 | ||
@test results["Site"]["renewable_electricity_fraction_bau"] ≈ 0.132118 atol=1e-3 #0.1354 atol=1e-3 | ||
@test results["Site"]["annual_renewable_electricity_kwh_bau"] ≈ 13308.5 atol=10 # 13542.62 atol=10 | ||
@test results["Site"]["total_renewable_energy_fraction_bau"] ≈ 0.132118 atol=1e-3 # 0.1354 atol=1e-3 | ||
# CO2 emissions - totals ≈ from grid, from fuelburn, ER, $/tCO2 breakeven |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not in your changes, but do you know what this comment means? it doesn't make any sense to me. what does ER stand for? Why is breakeven val in the list of what equals emissions totals? why approx equal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm this isn't my comment but I think it might mean: here we are testing some things related to CO2 Emissions Totals, including approx results for these things. ER = emissions reduction, I believe.
data/emissions/AVERT_Data
.