Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Emissions to Latest Data #460

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Update Emissions to Latest Data #460

wants to merge 15 commits into from

Conversation

adfarth
Copy link
Collaborator

@adfarth adfarth commented Dec 6, 2024

  • Updated AVERT emissions data to v4.3, which uses Regional Data Files for year 2023 for CONUS. For Alaska and Hawaii (regions AKGD, HIMS, HIOA), updated eGRID data to eGRID2022 datafile, adjusted to CO2e values. Emissions profiles are saved in data/emissions/AVERT_Data.
  • Updated Cambium API call for CO2e emissions within CONUS to Cambium 2023 dataset. This includes updates to the default values and valid options for the following ElectricUtility inputs: cambium_scenario, cambium_location_type, and cambium_start_year
  • Updated EMISSIONS_DECREASE_DEFAULTS from 0.02163 to 0.0459 based on Cambium 2023 data

@adfarth adfarth requested a review from hdunham December 23, 2024 19:13
Copy link
Collaborator

@hdunham hdunham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good I just had a couple questions with one maybe todo

src/REopt.jl Show resolved Hide resolved
src/core/electric_utility.jl Show resolved Hide resolved
"lifetime" => string(lifetime), # Integer 1 or greater (Default 25 yrs)
"discount_rate" => "0.0", # Zero = simple average (a pwf with discount rate gets applied to projected CO2 costs, but not quantity.)
"time_type" => "hourly", # hourly or annual
"metric_col" => metric_col, # lrmer_co2e
"smoothing_method" => "rolling", # rolling or none (only applicable to hourly queries). "rolling" best with TMY data; "none" best if 2012 weather data used.
"gwp" => "100yrAR6", # Global warming potential values. Default: "100yrAR6". Options: "100yrAR5", "20yrAR5", "100yrAR6", "20yrAR6" or a custom tuple [1,10.0,100] with GWP values for [CO2, CH4, N2O]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be reverted before merging?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh great catch. I don't think this necessarily needs to be reverted because [1, 29.8, 273.0] should == using "100yrAR6". However, it would be good to find out if "100yrAR6" is still a viable option (currently, it errors). I'm still waiting to hear back from the Cambium team on this so let's keep this as an open TODO.

@test !haskey(results, "Generator")
# Renewable energy
@test results["Site"]["renewable_electricity_fraction"] ≈ 0.78586 atol=1e-3
@test results["Site"]["renewable_electricity_fraction"] ≈ 0.745 rtol=0.01
@test results["Site"]["renewable_electricity_fraction_bau"] ≈ 0.132118 atol=1e-3 #0.1354 atol=1e-3
@test results["Site"]["annual_renewable_electricity_kwh_bau"] ≈ 13308.5 atol=10 # 13542.62 atol=10
@test results["Site"]["total_renewable_energy_fraction_bau"] ≈ 0.132118 atol=1e-3 # 0.1354 atol=1e-3
# CO2 emissions - totals ≈ from grid, from fuelburn, ER, $/tCO2 breakeven
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in your changes, but do you know what this comment means? it doesn't make any sense to me. what does ER stand for? Why is breakeven val in the list of what equals emissions totals? why approx equal?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm this isn't my comment but I think it might mean: here we are testing some things related to CO2 Emissions Totals, including approx results for these things. ER = emissions reduction, I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants