Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to overwrite automatic hybrid GHP sizing #459

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

lixiangk1
Copy link
Collaborator

Allows the user to specify if the auxiliary unit is heating or cooling in hybrid GHP

@lixiangk1 lixiangk1 requested a review from atpham88 December 5, 2024 00:40
@lixiangk1
Copy link
Collaborator Author

lixiangk1 commented Dec 5, 2024

@atpham88 Somewhat but not completely related, when I was testing this, I came across a case where if I selected "Heater", REopt produced a reasonable hybrid result, but if I selected "Cooler" ("Automatic" also selects a cooler in this case), REopt exited out of GhpGhx.jl after hitting the max number of iterations with some ridiculous result of 16,000 boreholes cause it didn't converge. GHP.ghpghx_chosen_outputs returned an empty dictionary. Which might be what's messing up the webtool outputs? What would be the ideal behavior in this case? Do we want to throw an error message whenever we hit max iterations because that most likely indicates a convergence issue and just return a non-hybrid result?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant