fix: Make ReEDS parser compatible with new cost functions #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 60.86% 62.18% +1.32%
==========================================
Files 29 29
Lines 3020 3115 +95
==========================================
+ Hits 1838 1937 +99
+ Misses 1182 1178 -4 ☔ View full report in Codecov by Sentry. |
List of changes: - Added new function called `haskey` for dictionaries with testing, - Updated cost function exporting to match changes on infrasys, - Updated pyproject to include new test marks, - Updated model to include operational cost
ktehranchi
reviewed
Sep 27, 2024
| match cost["class_type"]: | ||
| case "ThermalGenerationCost": | ||
| if shut_down := cost.get("start_up"): | ||
| component["Start Cost"] = shut_down |
There was a problem hiding this comment.
why not name the variable here start_up?
ktehranchi
reviewed
Sep 27, 2024
ktehranchi
reviewed
Sep 27, 2024
ktehranchi
reviewed
Sep 27, 2024
|
small comments but LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.