Skip to content

Commit

Permalink
More default values for previously required arguments.
Browse files Browse the repository at this point in the history
  • Loading branch information
joseph-robertson committed Nov 4, 2024
1 parent ca1885e commit 2f31f5b
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 3 deletions.
12 changes: 12 additions & 0 deletions BuildResidentialHPXML/measure.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5169,11 +5169,23 @@ def convertArgumentValues(arguments_model, args)

# TODO
def defaultOptionalArgumentValues(args)
# these were previously required arguments with default values set
args[:floor_over_foundation_assembly_r] = 28.1 if args[:floor_over_foundation_assembly_r].nil?
args[:floor_over_garage_assembly_r] = 28.1 if args[:floor_over_garage_assembly_r].nil?
args[:ceiling_assembly_r] = 31.6 if args[:ceiling_assembly_r].nil?
args[:geometry_roof_pitch] = '6:12' if args[:geometry_roof_pitch].nil?
args[:geometry_garage_width] = 0.0 if args[:geometry_garage_width].nil?
args[:geometry_garage_depth] = 20.0 if args[:geometry_garage_depth].nil?
args[:geometry_garage_protrusion] = 0.0 if args[:geometry_garage_protrusion].nil?
args[:geometry_garage_position] = Constants::PositionRight if args[:geometry_garage_position].nil?
args[:slab_perimeter_insulation_r] = 0 if args[:slab_perimeter_insulation_r].nil?
args[:slab_perimeter_insulation_depth] = 0 if args[:slab_perimeter_insulation_depth].nil?
args[:slab_under_insulation_r] = 0 if args[:slab_under_insulation_r].nil?
args[:slab_under_insulation_width] = 0 if args[:slab_under_insulation_width].nil?
args[:neighbor_front_distance] = 0.0 if args[:neighbor_front_distance].nil?
args[:neighbor_back_distance] = 0.0 if args[:neighbor_back_distance].nil?
args[:neighbor_left_distance] = 10.0 if args[:neighbor_left_distance].nil?
args[:neighbor_right_distance] = 10.0 if args[:neighbor_right_distance].nil?
args[:overhangs_front_depth] = 0 if args[:overhangs_front_depth].nil?
args[:overhangs_back_depth] = 0 if args[:overhangs_back_depth].nil?
args[:overhangs_left_depth] = 0 if args[:overhangs_left_depth].nil?
Expand Down
6 changes: 3 additions & 3 deletions BuildResidentialHPXML/measure.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>build_residential_hpxml</name>
<uid>a13a8983-2b01-4930-8af2-42030b6e4233</uid>
<version_id>e0310568-0b18-4bcf-a7b0-b3b494fa12da</version_id>
<version_modified>2024-11-04T17:16:56Z</version_modified>
<version_id>f395b10d-1835-4a9c-a974-84f065590fb2</version_id>
<version_modified>2024-11-04T17:29:08Z</version_modified>
<xml_checksum>2C38F48B</xml_checksum>
<class_name>BuildResidentialHPXML</class_name>
<display_name>HPXML Builder</display_name>
Expand Down Expand Up @@ -7628,7 +7628,7 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>4F540029</checksum>
<checksum>4DE55017</checksum>
</file>
<file>
<filename>constants.rb</filename>
Expand Down

0 comments on commit 2f31f5b

Please sign in to comment.