Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes possible "Sum of energy consumptions do not match total" error #699

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

shorowit
Copy link
Collaborator

@shorowit shorowit commented Dec 12, 2023

Pull Request Description

Fixes possible "Sum of energy consumptions do not match total" error for a shared water heater w/ FractionDHWLoadServed=0 (i.e., it only serves shared hot water appliances).

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • OS-HPXML git subtree has been pulled
  • 301/ES rulesets and unit tests have been updated
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Workflow tests have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI

@shorowit shorowit added the bug label Dec 12, 2023
@shorowit shorowit self-assigned this Dec 12, 2023
@shorowit shorowit merged commit 0d5a2c9 into master Dec 13, 2023
8 checks passed
@shorowit shorowit deleted the dhw_zero_load_served_error branch December 13, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant