Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZERH MF Ver2 Implementation #676

Merged
merged 28 commits into from
Dec 14, 2023
Merged

ZERH MF Ver2 Implementation #676

merged 28 commits into from
Dec 14, 2023

Conversation

bpark1327
Copy link
Collaborator

@bpark1327 bpark1327 commented Apr 19, 2023

Pull Request Description

ZERH MF Ver2 Implementation (https://www.energy.gov/sites/default/files/2023-03/DOE%20ZERH%20Multifamily%20V2%20-%20ERI%20Target%20Procedure%20DRAFT%20March%202023.pdf)

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • OS-HPXML git subtree has been pulled
  • 301/ES rulesets and unit tests have been updated
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Workflow tests have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI

@bpark1327 bpark1327 self-assigned this Apr 19, 2023
@bpark1327
Copy link
Collaborator Author

bpark1327 commented Apr 21, 2023

@shorowit ZERH MF Ver 2 has the specification for a unit served by a commercial water heating system:

"System Type (when Rated Unit is served by a commercial system): Same as system serving the Rated
Unit. For fossil-fuel boilers or water heaters, use 90% Et . For electric boilers or water heaters, use 2.2
COP."

Currently, we assume all water heaters are residential because we require EF/UEF. We may need to accommodate commercial water heaters and allow for thermal efficiency (Et) input.

@bpark1327

This comment was marked as resolved.

@bpark1327 bpark1327 marked this pull request as ready for review May 11, 2023 04:30
@bpark1327 bpark1327 requested a review from shorowit May 11, 2023 04:30
@shorowit

This comment was marked as resolved.

@bpark1327
Copy link
Collaborator Author

bpark1327 commented Jul 28, 2023

Need to update mech vent SRE -> ASRE

Addressed in commit 6a1110d

@bpark1327
Copy link
Collaborator Author

Updated to ZERH MF Ver2 released on 11/27/2023

Copy link
Collaborator

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @bpark1327. Looks good to me.

@shorowit shorowit merged commit 085d6cd into master Dec 14, 2023
@shorowit shorowit deleted the zerh_mf_v2 branch December 14, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants